curvefs/client: fix bug of support summary info in dir xattr #1150
Conversation
SeanHai
force-pushed
the
fixbug
branch
6 times, most recently
from
8e3d4e3 to
cc15aa4
Compare
|
recheck |
| // inodeid to parent inodeid, may have more parent at hard link | ||
| std::map<uint64_t, std::list<uint64_t>> parentIdMap_; | ||
| // inodeid to parent inodeid | ||
| std::map<uint64_t, uint64_t> parentIdMap_; |
There was a problem hiding this comment.
Does this only work if you turn it on?
There was a problem hiding this comment.
Does this only work if you turn it on?
Yes, the relationship is needed when turn on the enableSumInDir flag.
SeanHai
force-pushed
the
fixbug
branch
2 times, most recently
from
3c14d0c to
58cd8e5
Compare
| @@ -1297,10 +1301,6 @@ CURVEFS_ERROR FuseClient::FuseOpRelease(fuse_req_t req, fuse_ino_t ino, | |||
| return ret; | |||
| } | |||
|
|
|||
| if (enableSumInDir_) { | |||
There was a problem hiding this comment.
why not delete
Oplookup will not called when vfs cached the info of inode, so if delete the relationship when release maybe lost the parent.
| } | ||
| LOG(WARNING) << "AddParent but exist, inodeId = " << inodeId | ||
| << ", parentId = " << parentIdMap_[inodeId] | ||
| << ", need2AddParentId = " << parentId; |
There was a problem hiding this comment.
check old parent and new parent are equal?
There was a problem hiding this comment.
check old parent and new parent are equal?
fixed
There was a problem hiding this comment.
if (parentIdMap_.count(inodeId) && parentIdMap_[inodeId] != parentId)
what happens here?
There was a problem hiding this comment.
if (parentIdMap_.count(inodeId) && parentIdMap_[inodeId] != parentId) what happens here?
It won't happen normally, just do anomaly detection.
…ent relationship is not correct.
|
recheck |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List